Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Jianjun Wang. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot tables: Add PCIe info to coreboot table ......................................................................
Patch Set 9: Code-Review+1
(2 comments)
Patchset:
PS9: LGTM from a general coding point of view now, someone who knows the PCIe stuff should review for +2.
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/6f28bd05_934c0253 PS9, Line 146: }; Thanks! Can you please also add a
_Static_assert(sizeof(struct lb_pcie) == 36, "lb_uint64_t alignment doesn't work as expected for struct lb_pcie!");
here so that we can be sure this keeps working as it should?
...I feel almost tempted to also change all of these to use a
#define LB_STRUCT(name, contents) struct name { contents }; \ _Static_assert(alignof(struct name) == 4, #name " is not 4-byte aligned. Make sure you use lb_uint64_t instead of uint64_t for all 8-byte members!")
so that it's less likely people will add these wrong in the future. What do you think, is that overkill?