Attention is currently required from: Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro() ......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS2:
I'll look into it, but would probably need a new Kconfig.
My plan about these "mode switches" and their weak alternatives:
Advice to build the files with switch implementations (mb or variant bootmode.c) with all-y. We can make the builds fail for cases where these functions are called too early. Like attempting to read lid in bootblock where EC comms might not be possible. Put some if (ENV_ROMSTAGE_OR_BEFORE) call unresolved symbol?
We could also declare the default switch states as weak functions in one common file. Part of the weak implementation is to keep track that we hit the weak function and to have a one/two line entry in console logs telling that the requested switch has not been implemented (yet).
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/62904e06_6b06e5ce PS5, Line 14: void fill_lb_gpios(struct lb_gpios *gpios) I do not see a "EC in RW" entry here.
-
Kyösti Mälkki (Code Review)