Attention is currently required from: Angel Pons, Nico Huber.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84011?usp=email )
Change subject: nvramcui: Fix main function signature
......................................................................
Patch Set 3:
(1 comment)
File payloads/nvramcui/nvramcui.c:
https://review.coreboot.org/c/coreboot/+/84011/comment/491d440e_50234768?usp... :
PS1, Line 162: *argv
I've seen both, I prefer `char *argv[]` because it better conveys intent (`argv` is an array of strings)
It is but this patch is about just matching signatures. Fixing this in libpayload would a different topic which may involve downstream changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0c50224bd70503e884573fedf3bf33c134bba00
Gerrit-Change-Number: 84011
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 23 Aug 2024 10:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com