Change in coreboot[master]: soc/intel/skylake: Enable SMBus depending on devicetree configuration
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43845 )
Change subject: soc/intel/skylake: Enable SMBus depending on devicetree configuration ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43845/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43845/4/src/mainboard/google/voltee... PS4, Line 32: chip soc/intel/tigerlake
Hey, this is Volteer
oops, thanks!
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst... File src/soc/intel/skylake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst... PS4, Line 300: config
no
Done
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst... PS4, Line 302: dev ? dev->enabled : 0
dev && dev->enabled
I would leave it like that to keep the consistency, since the existing code is handled like that.
I will rework that in a follow-up.
-
Felix Singer (Code Review)