Attention is currently required from: Angel Pons, Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM ......................................................................
Patch Set 10:
(3 comments)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/81409/comment/af63a1c8_75b690f4?usp... : PS9, Line 98: bool has_cdm; : int cdm_index;
Redundancy. I wasn't feeling great when writing that. […]
Done
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/81409/comment/0c9d6e21_8083701c?usp... : PS9, Line 170: acpigen_write_method("_CDM", 1);
Could this be a Name instead? Or does it need to be a Method?
Has to be method, assume driver is badly written 😊
https://review.coreboot.org/c/coreboot/+/81409/comment/4223250b_dd8fea83?usp... : PS9, Line 171: +
Any reason not to use a bitwise OR?
Done