Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83925?usp=email )
Change subject: soc/mediatek/mt8196: Enable mmu operation for L2C SRAM and DMA
......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/common/l2c_ops.c:
https://review.coreboot.org/c/coreboot/+/83925/comment/e1aa1f79_0ace6300?usp... :
PS1, Line 24: __asm__ volatile ("mrs %0, S3_0_C15_C3_7" : "=r" (v));
add one tab
Done
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/83925/comment/ac3ee4ae_e036eb19?usp... :
PS1, Line 6: #include <soc/mmu_operations.h>
sort
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83925?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a3cb63d3418f085f5d8d08b282dd59ea431c294
Gerrit-Change-Number: 83925
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 09:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com