Attention is currently required from: Máté Kukri, Nico Huber.
Angel Pons has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email )
Change subject: mb/dell/optiplex_9020: Fix UB challenged package power calculation ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83736/comment/25655f20_09127fa4?usp... : PS1, Line 7: UB challenged What does "UB challenged" mean?
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83736/comment/ef057a87_d3b0d514?usp... : PS1, Line 306: unsigned int pkg_power, power_unit; : pkg_power = rdmsr(0x614).lo & 0x7fff; : power_unit = 1 << (rdmsr(0x606).lo & 0xf); ```suggestion const unsigned int pkg_power = rdmsr(0x614).lo & 0x7fff; const unsigned int power_unit = 1 << (rdmsr(0x606).lo & 0xf); ```
https://review.coreboot.org/c/coreboot/+/83736/comment/03e46514_15af6ec7?usp... : PS1, Line 309: 0x41 nit: `65` is a more meaningful value