Attention is currently required from: Balaji Manigandan, Jamie Ryu, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Restrict TBT displays(DPOF) on S0ix transition to FWCM.
......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75717/comment/d7afbf8a_00826245 :
PS3, Line 7: displays(DPOF)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/75717/comment/335812c1_329c2928 :
PS3, Line 9: IOM needed to be notified about DPOF(TBT Displays OFF) only when Firmware connection Manager in use during S0ix Entry/Exit.
Where is that documented?
https://review.coreboot.org/c/coreboot/+/75717/comment/5dac56eb_54dda8e0 :
PS3, Line 9: Firmware connection Manager
What is that?
https://review.coreboot.org/c/coreboot/+/75717/comment/c9e82ffe_fbd28c71 :
PS3, Line 9: Manager in
… is in …
https://review.coreboot.org/c/coreboot/+/75717/comment/b46fe2ad_dc4d5762 :
PS3, Line 9: DPOF(TBT Displays OFF) only
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/75717/comment/95343ca8_04564fe0 :
PS3, Line 9: needed
needs
https://review.coreboot.org/c/coreboot/+/75717/comment/b110b6a7_bbb47e73 :
PS3, Line 10:
Please add a bug number.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13
Gerrit-Change-Number: 75717
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: Vikrant Jadeja
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vikrant Jadeja
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 23:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment