Attention is currently required from: YH Lin, Joey Peng.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59947 )
Change subject: mb/google/brya/variant/taniks: Upload memory settings
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/brya/variants/taniks/memory.c:
https://review.coreboot.org/c/coreboot/+/59947/comment/de280bc9_1ff3a937
PS3, Line 69: *__weak
remove this in order to override the code from the baseboard 👍
https://review.coreboot.org/c/coreboot/+/59947/comment/a4f4176f_d424741e
PS3, Line 74: __weak
same here
https://review.coreboot.org/c/coreboot/+/59947/comment/2e126365_2e23fc66
PS3, Line 93: __weak
and here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c0794fb94d1f6271de604835ae1d2b20696ee70
Gerrit-Change-Number: 59947
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 08 Dec 2021 21:54:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment