Attention is currently required from: Jason Glenesk, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Paul Menzel.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
PS2:
Acknowledged
I don't see the change here.
Please link the CL here if it's going to be done separately.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76091/comment/8a201a78_02bb72ce :
PS5, Line 266: and
nit: 'an'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 20:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@gmail.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment