Attention is currently required from: Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51148 )
Change subject: soc/intel/cannonlake: Move `gpi_clear_int_cfg()` call ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51148/comment/5912c4a3_f9813aec PS1, Line 9: To allow unifying bootblock.c in follow-ups, move a function call. Change from `bootblock_soc_init()` to `bootblock_pch_init()` looks okay to me since it is moved after `report_platform_info()` instead of before.
File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/51148/comment/95798b4c_bd3b181c PS1, Line 139: gpi_clear_int_cfg Not for this change:
This is something that is required for every platform. It has been added to cannonlake/ and apollolake/ based on the problems that were observed on certain mainboard configurations for these platforms. But, it is really required for all Intel platforms. Also, I don't think there is anything that requires this to be done early on in bootblock. I think what we should do is -- add a boot state step just before jumping to payload or resuming to OS to clearing the interrupt status/enable registers in soc/common/block/gpio.
-
Furquan Shaikh (Code Review)