Attention is currently required from: Patrick Georgi, Furquan Shaikh, Subrata Banik, Paul Menzel, Nick Vaccaro, Angel Pons, Robert Chen, Marco Chen, Shon Wang, Name of user not set #1004174, Karthik Ramasubramanian, Xiang Liu.
Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT
......................................................................
Patch Set 11:
(3 comments)
File src/drivers/i2c/cs35l53/chip.h:
https://review.coreboot.org/c/coreboot/+/61448/comment/9108633f_6a602af5
PS10, Line 31: };
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/61448/comment/e8eedd95_28a30779
PS10, Line 33: enum cs35l53_gpio2_src {
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/61448/comment/7e7dc5d0_5c2aa8f1
PS10, Line 40: };
please, no spaces at the start of a line
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606
Gerrit-Change-Number: 61448
Gerrit-PatchSet: 11
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Name of user not set #1004174
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Vitaly Rodionov
vitaly.rodionov@gmail.com
Gerrit-CC: Xiang Liu
xiang.liu@cirrus.corp-partner.google.com
Gerrit-CC: YH Lin
yueherngl@chromium.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Name of user not set #1004174
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Xiang Liu
xiang.liu@cirrus.corp-partner.google.com
Gerrit-Comment-Date: Wed, 16 Mar 2022 03:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment