Attention is currently required from: Henry Sun, Paul Menzel, Marco Chen. Paul2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59859 )
Change subject: mb/google/octopus/var/ampton: add touchscreen into SSFC support ......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59859/comment/c4acbf72_a3a0a2bf PS8, Line 9: ELAN9008(eKTH6913UAY)
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/59859/comment/be919058_b756743c PS8, Line 14: work
works
Done
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h:
https://review.coreboot.org/c/coreboot/+/59859/comment/9ab5545f_307e89cd PS7, Line 44: SSFC_TOUCHSCREEN_ELAN9008,
- Could you have them with different i2c slave address by either FW or HW strap pin? […]
(1) Checking with EE and vendor (2) Yes, if ELAN0001 and ELAN9008 both exist in overridetree.cb, then touchscreen no function, until we remove ELAN0001 from overridetree.cb.