Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49249 )
Change subject: sb/intel/common: Change some SMI logging ......................................................................
sb/intel/common: Change some SMI logging
Change-Id: Ief0c3d36e6de6e18b7f2613f043ac4d31a193f9d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/dell/optiplex_9010/smihandler.c M src/mainboard/google/butterfly/smihandler.c M src/mainboard/google/parrot/smihandler.c M src/southbridge/intel/common/smihandler.c 4 files changed, 2 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/49249/1
diff --git a/src/mainboard/dell/optiplex_9010/smihandler.c b/src/mainboard/dell/optiplex_9010/smihandler.c index f3ba57c..1c7d328 100644 --- a/src/mainboard/dell/optiplex_9010/smihandler.c +++ b/src/mainboard/dell/optiplex_9010/smihandler.c @@ -6,11 +6,6 @@ #include <cpu/x86/smm.h> #include <superio/smsc/sch5545/sch5545.h>
-void mainboard_smi_gpi(u32 gpi_sts) -{ - printk(BIOS_SPEW, "%s: gpi_sts: %08x\n", __func__, gpi_sts); -} - int mainboard_smi_apmc(u8 data) { u8 val; @@ -38,8 +33,3 @@ } return 0; } - -void mainboard_smi_sleep(u8 slp_typ) -{ - printk(BIOS_SPEW, "%s: SMI sleep: %02x\n", __func__, slp_typ); -} diff --git a/src/mainboard/google/butterfly/smihandler.c b/src/mainboard/google/butterfly/smihandler.c index 0ffa0e6..ac38790 100644 --- a/src/mainboard/google/butterfly/smihandler.c +++ b/src/mainboard/google/butterfly/smihandler.c @@ -13,15 +13,8 @@ #include <ec/quanta/ene_kb3940q/ec.h> #include "ec.h"
-void mainboard_smi_gpi(u32 gpi_sts) -{ - printk(BIOS_DEBUG, "warn: unknown mainboard_smi_gpi: %x\n", gpi_sts); -} - void mainboard_smi_sleep(u8 slp_typ) { - printk(BIOS_DEBUG, "mainboard_smi_sleep: %x\n", slp_typ); - /* Tell the EC to Enable USB power for S3 if requested */ if (gnvs->s3u0 != 0 || gnvs->s3u1 != 0) ec_mem_write(EC_EC_PSW, ec_mem_read(EC_EC_PSW) | EC_PSW_USB); diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index 89d4cac..9b53bc4 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -36,7 +36,6 @@
void mainboard_smi_gpi(u32 gpi_sts) { - printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts); if (gpi_sts & (1 << EC_SMI_GPI)) { /* Process all pending events from EC */ while (mainboard_smi_ec() != EC_NO_EVENT); @@ -51,7 +50,6 @@
void mainboard_smi_sleep(u8 slp_typ) { - printk(BIOS_DEBUG, "mainboard_smi_sleep: %x\n", slp_typ); /* Disable SCI and SMI events */
/* Clear pending events that may trigger immediate wake */ diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index 7256497..07cd662 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -113,9 +113,10 @@
/* Figure out SLP_TYP */ reg32 = read_pmbase32(PM1_CNT); - printk(BIOS_SPEW, "SMI#: SLP = 0x%08x\n", reg32); slp_typ = acpi_sleep_from_pm1(reg32);
+ printk(BIOS_SPEW, "SMI#: SLP = 0x%08x, TYPE = 0x%02x\n", reg32, slp_typ); + southbridge_smm_xhci_sleep(slp_typ);
/* Do any mainboard sleep handling */