Attention is currently required from: Paul Menzel.
Solomon Alan-Dei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68941 )
Change subject: arch/x86: fix copying beyond eos in smbios struct ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68941/comment/d887a2da_508188bf PS2, Line 7: src/
Please remove.
Done
https://review.coreboot.org/c/coreboot/+/68941/comment/9105b773_70376aa7 PS2, Line 9: Coverity scan indicated there may be a copy beyond eos in : smbios struct declared in smbios.h but the code is intentional. : This type of issue is fixed by assigning the source for the text string : to a const pointer, and passing the pointer to smbios_add_string calls : in smbios_defaults.c
Please reflow for 72 characters per line, and add exactly one blank line between paragraphs. […]
Done
https://review.coreboot.org/c/coreboot/+/68941/comment/1a7428e8_ac14c575 PS2, Line 14: CID: 1487449
Found-by: Coverity (CID 1487449: …)
Done
Patchset:
PS4: Thank you for pointing out the issues. Kindly check if they’re resolved.