Attention is currently required from: Arthur Heymans, Felix Singer, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83327?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/intel/beechnutcity_crb: Update SMBIOS type 0,1,2,3 info ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/intel/beechnutcity_crb/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83327/comment/d204ef80_7363f639?usp... : PS5, Line 14: return "UNKNOWN"; Default if unset is the coreboot version, which IMHO is more useful than "UNKNOWN": https://github.com/coreboot/coreboot/blob/c19e32e69d8a9e42346fe81432bbdfc1e1...
https://review.coreboot.org/c/coreboot/+/83327/comment/31b46095_383886d6?usp... : PS5, Line 24: return "UNKNOWN"; Most of these default to empty strings. Will this code be changed in the future (e.g. when details are no longer embargoed)? If so, maybe add TODO comments to clarify this is temporary.
If this will not be updated, is there a reason to return `"UNKNOWN"` instead of `""`?
https://review.coreboot.org/c/coreboot/+/83327/comment/ee515352_42cefae9?usp... : PS5, Line 52: u8 smbios_chassis_power_cords(void) : { : return 1; : } Same as default, can be omitted: https://github.com/coreboot/coreboot/blob/c19e32e69d8a9e42346fe81432bbdfc1e1...