[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot

[Dinesh Gehlot (Code Review)]

Attention is currently required from: Kapil Porwal, Subrata Banik.

Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75755?usp=email )

Change subject: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot
......................................................................

Patch Set 11:

(7 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/75755/comment/5aebf2e9_a5fc0f06 :
PS9, Line 137: static bool is_cse_fw_updated, is_cold_boot;
> use a structure with two member variable (if needed)

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/d1b8eae4_1951f367 :
PS9, Line 1205: 		/* cse has been updated*/
> space?

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/d9e559ba_96d1c1af :
PS9, Line 1207: 		/* write cse rw fw version to CMOS and CBMEM */
>

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/a4e7b603_7bf74bdc :
PS9, Line 1211: /* Current running CSE version is same as previous stored CSE version */
>

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/7a6fdff3_a88bea0d :
PS9, Line 1218: memcpy(&(version->cur_cse_fw_version), &(cse_bp->fw_ver), size);
> can we do something like this at line#1220 (outside loop) and drop this line here and from 1209 as w […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/1744f52e_5918ab4e :
PS9, Line 1306: 			set_cmos_ish_version(&(resp.manifest_data.version));
              : 			memcpy(&(version->ish_partition_info.cur_ish_fw_version),
              : 				&(resp.manifest_data.version), size);
>

Acknowledged

https://review.coreboot.org/c/coreboot/+/75755/comment/601edb82_f03ecaab :
PS9, Line 1311: /*
              : 		 * The CBMEM was reset during cold reboot, so the ISH version in CBMEM
              : 		 * needs to be updated to the version stored in CMOS.
              : 		 */
>

Acknowledged