[XS] Change in coreboot[main]: Makefile.mk: Remove linker warning on RWX segments - coreboot-gerrit

2 Aug 2024


      Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83559?usp=email )
Change subject: Makefile.mk: Remove linker warning on RWX segments
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
...
Thanks. Yes we plan to upgrade binutils in ChromiumOS. […]
`xcompile` kind of abstracts the toolchain version. It has code for exactly
the kind of check that is needed here. `Makefile.mk` should have all the
options that are common across all (supported) toolchain versions. I think
it's right to keep support for at least some older toolchain versions.
We should go ahead with CB:83693 anyway. If you could test if it fixes your
issue, that'd be nice :)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83559?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1e0f51c69dabaea314ac45924474d446a9ab68f4
Gerrit-Change-Number: 83559
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 02 Aug 2024 13:07:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com