Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Eric Herrmann has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75764?usp=email )
Change subject: mb/google/rex: Set FVM configuration for MTL-P 28W ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75764/comment/291ace48_133a9abc : PS1, Line 60: register "cep_enable[VR_DOMAIN_IA]" = "1" what is cep enable?
https://review.coreboot.org/c/coreboot/+/75764/comment/b4efbe3d_032983a1 : PS1, Line 61: register "fast_vmode_i_trip[VR_DOMAIN_IA]" = "372" # 93A I think these are out of date. The document I have is 91A, 54A, and 27A respectively.
Does this get programmed into the PMIC via SVID or is it kept internally? Since these are nominal values, does this value assume some tolerance?
-
Eric Herrmann (Code Review)