[M] Change in coreboot[main]: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures

[Sowmya Aralguppe (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Pratikkumar V Prajapati, Subrata Banik, Tarun.

Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email )

Change subject: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures
......................................................................

Patch Set 19:

(5 comments)

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/83106/comment/b99d2e37_65886948?usp... :
PS19, Line 352: cl_buffer
> this is now combined dw0 and dw1, if so, then why are we calling it as `cl_buffer`. […]

The lopping is  done for number of child crashlog records and each child crahlog will hold buffer size and offset where the CL is .
It is named same as cpu_cl_disc_tab.buffers[i].data .

https://review.coreboot.org/c/coreboot/+/83106/comment/6e1b176f_dc83118e?usp... :
PS19, Line 353: */
> space before ?

will correct it

https://review.coreboot.org/c/coreboot/+/83106/comment/041dad2a_05e95f9a?usp... :
PS19, Line 354: 		if (!(cl_buffer >> 32))
> this can check if MSB is zero or not. Not sure what is the purpose ? […]

it is cl buffer because it is same as cpu_cl_disc_tab.buffers[i].data - the upper 32 bits reads buffer size and lower 32 bytes is offset .If the size is 0 then there is no point in going further so we continue

https://review.coreboot.org/c/coreboot/+/83106/comment/3593abe7_ccb49524?usp... :
PS19, Line 357: 	u32 dw0 = read32p(disc_tab_addr + cur_offset);
> this is same as https://review.coreboot.org/c/coreboot/+/83106/19/src/soc/intel/meteorlake/c.... […]

Crashlog_data_valid This is done for reading the header in line 342
The 31st bit will be set if the crashlog record has been already consumed

File src/soc/intel/tigerlake/crashlog_lib.c:

https://review.coreboot.org/c/coreboot/+/83106/comment/bd4739e4_f94f49b1?usp... :
PS19, Line 165: bar_addr
> we should check if this value is non-zero ?

yes correct - will correct it - i had not changed anything in TGL other than pointer casting that are in common code