Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic, Maximilian Brune.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80184?usp=email )
Change subject: arch/arm64/armv8: Add exception output without printk
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/arch/arm64/armv8/exception.c:
https://review.coreboot.org/c/coreboot/+/80184/comment/ef9a24c8_0136381a :
PS1, Line 113: if (idx < 10)
: __uart_tx_byte('0' + (char)idx);
: else if (idx < 16)
: __uart_tx_byte('A' - 10 + (char)idx);
: __uart_tx_byte('!');
: UART_DIRECT_PRINT(raw_read_esr(), 32)
: __uart_tx_byte('!');
Sounds good. But I will have to write it like this (even if it is taking a bit more space): […]
Hmm... yeah okay, there seems to be no way to force GCC to use PC-relative addressing for that string. That's a bit frustrating. Guess your solution is the best we can do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f858730469fff3cae120fd7c32fec53b3d309ca
Gerrit-Change-Number: 80184
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Tue, 06 Feb 2024 20:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment