Change in coreboot[master]: acpi/device: Add ability to generate proper _STA for PowerResource

[Lance Zhao (Code Review)]

Attention is currently required from: Raul Rangel, Furquan Shaikh, Tim Wawrzynczak.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )

Change subject: acpi/device: Add ability to generate proper _STA for PowerResource
......................................................................


Patch Set 2:

(1 comment)

File src/include/acpi/acpi_device.h:

https://review.coreboot.org/c/coreboot/+/55027/comment/773395a2_fbb2c3da 
PS2, Line 459: 
             : 	/* Write a _STA method that checks the state of the GPIOs. Otherwise
             : 	 * the _STA method will always return _ON.
             : 	 */
             : 	bool enable_status;
It looks the comment and name of bool need to explain a litter bit better for next person whom will define acpi power resource. Otherwise my first impression will be enable_status=0 will be _STA to off and enable_status=1 will be _STA to on.
What about change to "force_on" or "always enabled" or something similar?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5
Gerrit-Change-Number: 55027
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Furquan Shaikh <[e-mail]>
Gerrit-Attention: Tim Wawrzynczak <[e-mail]>
Gerrit-Comment-Date: Tue, 01 Jun 2021 01:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment