Change in coreboot[master]: include/device: Generic interface for USB-C mux operations - coreboot-gerrit

1 Oct 2021


      Attention is currently required from: Tim Wawrzynczak, Derek Huang.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58002 )
Change subject: include/device: Generic interface for USB-C mux operations
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/include/usbc_mux.h:
https://review.coreboot.org/c/coreboot/+/58002/comment/9c173222_26eca731 
PS3, Line 13: uint8_t
...
This field indicates DP pin assignment: […]
Can you please add the mode details to the comment as well? I think that would be helpful for users in the future.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5435f2054d1c9f114b06c3b4643e34713290e0d
Gerrit-Change-Number: 58002
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-MessageType: comment