Attention is currently required from: Tim Wawrzynczak, Sugnan Prabhu S, Ravindra, Michael Niewöhner, Patrick Rudolph, Ravindra N.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57783 )
Change subject: cpu/intel/common: Update CPPCv3 Nominal Frequency entry
......................................................................
Patch Set 7:
(1 comment)
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/57783/comment/13b201a7_a1d3e6e7
PS7, Line 136: CPPC_DWORD(0);
The difference is: CPPC_UNSUPPORTED resulting in `{Register {(SystemMemory, 0, 0, 0, 0)}` which the […]
@Tim/Michael,
Correct, here I am just initializing the element to ZERO.
In my follow-up patches, I will be updating the element with Nominal Frequency in the file#src/soc/intel/common/block/acpi/acpi.c.
As these changes are from 2 difference code directories, with this patch, I am setting the CPPC_NOMINAL_FREQ element to ZERO. In other patch, I will be updating the element with Nominal Frequency. I will expose all my patch train for review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If39e5e4ac77a71b143cdb5f043fb398abb398ee3
Gerrit-Change-Number: 57783
Gerrit-PatchSet: 7
Gerrit-Owner: Ravindra
ravindra@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravindra N
ravindra@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Ravindra
ravindra@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Ravindra N
ravindra@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 20:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment