Attention is currently required from: Crystal Guo, Hung-Te Lin, Xi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80687?usp=email )
Change subject: soc/mediatek: Move `get_sdram_config` to common code
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80687/comment/c4a101a5_a060c1ef :
PS2, Line 9: Starting from MT8195
People would need to know the history of MediaTek platforms in order to understand what this means exactly. Therefore I'd prefer an explicit list of SoCs here (and in the code).
File src/soc/mediatek/common/memory.c:
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05a01b1ab13fbf19b2a908c48a540a5c2e1ccbdc
Gerrit-Change-Number: 80687
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 23 Feb 2024 01:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment