Attention is currently required from: Henry Sun, Bob Moragues, Julius Werner.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60130 )
Change subject: google/trogdor: Enable Parade ps8640 edp bridge for pazquel
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60130/comment/a2c2772d_2c857752
PS1, Line 7: UPSTREAM
This *is* upstream. You don't need to write UPSTREAM: in front of patch subjects here.
yes,remove it
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60130/comment/28317981_18c09fab
PS1, Line 87: 4
Please write as either 0x4 or BIT(2). Also, please put the (... & ... […]
ok, I have modified it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071
Gerrit-Change-Number: 60130
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kelsey Wang
peihwang@qualcomm.corp-partner.google.com
Gerrit-CC: Patrick Chang
changp@qualcomm.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 16 Dec 2021 02:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment