Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Konrad Adamczyk, Martin L Roth, Matt DeVillier, Paul Menzel, Raul Rangel.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76107?usp=email )
Change subject: vendorcode/amd/fsp/common: Refactor dmi_info.h
......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/amd/fsp/common/dmi_info.h:
https://review.coreboot.org/c/coreboot/+/76107/comment/4d1db78f_b0e34cb2 :
PS2, Line 144: } DMI_T17_MEMORY_TYPE;
That's valid point (in fact, more enums/structs defined in this file might be reused here). […]
Yes, I agree. we can clean up if we have better idea. What I am trying to say is if something is defined in smbios, we can rely on smbios to decode. FSP can report the enum and just pass to cbmem dmi table, let coreboot to decode it. Assume the value is followed the smbios spec.
SoC level todo is bypass the FSP mem_hob and fill the dmi_info. SoC don't need the detail here since FSP already do the job, and smbios will do it too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76107?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e0109af51b78360f7038b20a2975aceb721a7d5
Gerrit-Change-Number: 76107
Gerrit-PatchSet: 2
Gerrit-Owner: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Jun 2023 15:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konrad Adamczyk
konrada@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment