Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: drivers: spi_flash: Addressing mode change for SPI NOR ......................................................................
Patch Set 113:
(5 comments)
File src/drivers/spi/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396): https://review.coreboot.org/c/coreboot/+/50586/comment/0aee853d_2adf826e PS113, Line 169: This will send an Exit 4-Byte Address Mode (E9h) command before the first trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396): https://review.coreboot.org/c/coreboot/+/50586/comment/3b43fcab_44c3cf00 PS113, Line 170: access to the SPI flash. On some platforms with SPI flashes larger than 32MB, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396): https://review.coreboot.org/c/coreboot/+/50586/comment/988ce7f3_fc37f804 PS113, Line 171: the SPI flash may power up in 4-byte addressing mode and this command needs trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396): https://review.coreboot.org/c/coreboot/+/50586/comment/7b6b81b8_10ac45de PS113, Line 172: to be sent before coreboot's 3-byte address commands can be interpreted correctly. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396): https://review.coreboot.org/c/coreboot/+/50586/comment/c544b570_b779ed68 PS113, Line 173: On flashes that don't support 4-byte addressing mode or where it is already trailing whitespace