Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Piotr Król, Piotr Kubaj.
Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81963?usp=email )
Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81963/comment/e3a0931a_019828e4 :
PS2, Line 8:
It is rather unlikely to submit patches with no description at all. We would like to learn what is the reason behind this change, and what it brings. Some information what has been tested would be nice, too. Even here you had an example: https://github.com/Dasharo/coreboot/pull/423
Patchset:
PS2:
Does it make sense not to squash these patches into one? It seems both are needed to provide this feature, being part of one logical change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81963?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88
Gerrit-Change-Number: 81963
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Kubaj
pkubaj@anongoth.pl
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Piotr Kubaj
pkubaj@anongoth.pl
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 13:48:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment