Attention is currently required from: Jeremy Soller, Nick Vaccaro, Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60143 )
Change subject: drivers/intel/pmc_mux/conn: Change usb{23}_port_number fields to device pointers
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135853):
https://review.coreboot.org/c/coreboot/+/60143/comment/67371c27_b37c803c
PS3, Line 19: static unsigned int get_usb_port_number(const struct device *usb_port) {
open brace '{' following function definitions go on the next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5045b8ea57e8ca6f9ebd7d68a19486736b7e2809
Gerrit-Change-Number: 60143
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 20 Dec 2021 00:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment