Attention is currently required from: Tarun Tuli, Paul Menzel, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos.
Morris Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 )
Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72775/comment/514a6857_a0922e36 PS4, Line 7: SOLDERDOWN
Maybe: Configure for soldered down memory
SOLDERDOWN means memory soldered on board.
https://review.coreboot.org/c/coreboot/+/72775/comment/d48b2627_ea14443c PS4, Line 7: SOLDERDOWN
Maybe: Configure for soldered down memory
SOLDERDOWN means memory soldered on board.
File src/mainboard/google/brya/variants/constitution/memory.c:
https://review.coreboot.org/c/coreboot/+/72775/comment/51b5f5d4_268bd8f6 PS4, Line 14: /* Baseboard Rcomp target values */
Where did you get these from?
It comes from baseboard brya.
https://review.coreboot.org/c/coreboot/+/72775/comment/dc311536_493831eb PS4, Line 14: /* Baseboard Rcomp target values */
Where did you get these from?
Refer to intel doc#573387 to calculate value.
https://review.coreboot.org/c/coreboot/+/72775/comment/6300dcd9_79127e2b PS4, Line 15: .targets = {40, 30, 30, 30, 30},
Below there is a space after { and before }.
This format is as same as baseboard brya, do you mean I should delete a space and makes it like .targets={40,30,30,30,30} ?
https://review.coreboot.org/c/coreboot/+/72775/comment/d36d9a09_da22790e PS4, Line 18: /* DQ byte map */
Where did you get these from? Please add the document number to the comment.
Refer to intel doc#573387 to calculate value.
https://review.coreboot.org/c/coreboot/+/72775/comment/c4318b74_b440ec50 PS4, Line 18: /* DQ byte map */
Where did you get these from? Please add the document number to the comment.
Refer to intel doc#573387 and calculate value.
-
Morris Hsu (Code Review)