Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30021
to look at the new patch set (#4).
Change subject: mainboard/lenovo: Add ThinkPad T431s ......................................................................
mainboard/lenovo: Add ThinkPad T431s
The code is based on autoport and that for T430s
Tested: - CPU i5-3337U - Slotted DIMM 2GiB - Soldered RAM 4GiB from samsung (There may be more models here) - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - TPM1 on LPC - EHCI debug on SSP2 (USB3 port on the left) - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from Linux payload (Heads), Seabios may also work.
Not tested: - Fingerprint reader on USB2 (not present on mine) - Keyboard backlight (not present on mine) - "sticky_fn" flag in nvram
Not implemented yet: - Fn locking in nvram (may not be identical to "sticky_fn") - Detecting the model of Soldered RAM at runtime, and loading the corresponding SPD datum (3 observed) from CBFS (the mechanism may be similar to that on x1_carbon_gen1 and s230u, but I do not know how to find gpio ports for that, and SPD data stored in vendor firmware.)
Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Signed-off-by: Bill XIE persmule@gmail.com --- M Documentation/mainboard/index.md A Documentation/mainboard/lenovo/t431s.md A Documentation/mainboard/lenovo/t431s_bc_removed.jpg A Documentation/mainboard/lenovo/t431s_flash_chip.jpg A Documentation/mainboard/lenovo/t431s_programming.jpg A src/mainboard/lenovo/t431s/Kconfig A src/mainboard/lenovo/t431s/Kconfig.name A src/mainboard/lenovo/t431s/Makefile.inc A src/mainboard/lenovo/t431s/acpi/ec.asl A src/mainboard/lenovo/t431s/acpi/platform.asl A src/mainboard/lenovo/t431s/acpi/superio.asl A src/mainboard/lenovo/t431s/acpi_tables.c A src/mainboard/lenovo/t431s/board_info.txt A src/mainboard/lenovo/t431s/cmos.default A src/mainboard/lenovo/t431s/cmos.layout A src/mainboard/lenovo/t431s/data.vbt A src/mainboard/lenovo/t431s/devicetree.cb A src/mainboard/lenovo/t431s/dsdt.asl A src/mainboard/lenovo/t431s/gma-mainboard.ads A src/mainboard/lenovo/t431s/gpio.c A src/mainboard/lenovo/t431s/hda_verb.c A src/mainboard/lenovo/t431s/mainboard.c A src/mainboard/lenovo/t431s/romstage.c A src/mainboard/lenovo/t431s/smihandler.c A src/mainboard/lenovo/t431s/spd/Makefile.inc A src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex A src/mainboard/lenovo/t431s/thermal.h 27 files changed, 1,268 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/30021/4