Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support ......................................................................
Patch Set 4:
(5 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/5f954dc0_e6db4caa?usp... : PS4, Line 29: SOC_INTEL_IOE_DIE_SUPPORT we should keep this to ensure P2SB#2 support exists
https://review.coreboot.org/c/coreboot/+/83419/comment/2699b750_0043c412?usp... : PS4, Line 13: if !SIMICS_ENV please drop the simics support. if you need to keep simics support then better create a separate board.
Assume we are creating google/fatcat and while testing this binary on simics, we can keep one WIP CL to boot into the simics. not necessarily we need to keep simics support inside the code itself.
https://review.coreboot.org/c/coreboot/+/83419/comment/0ba60d1c_8a734652?usp... : PS4, Line 16: DRIVERS_UART_8250IO this is non-POR for chrome board
https://review.coreboot.org/c/coreboot/+/83419/comment/c0b9e365_5003190b?usp... : PS4, Line 30: SOC_INTEL_PANTHERLAKE_A0 SOC_INTEL_PANTHERLAKE_U_H
https://review.coreboot.org/c/coreboot/+/83419/comment/c1add0cd_ddf0a97b?usp... : PS4, Line 108: config SIMICS_ENV : default y : drop this as we don't need, plus the Kconfig implementation itself is not correct
``` #!!!!! Error: No type defined for symbol SIMICS_ENV defined at src/mainboard/google/fatcat/Kconfig:108. # 1 errors ```