Attention is currently required from: Felix Held, Felix Singer, Jérémy Compostella, Shuo Liu, yuchi.chen@intel.com.
Hello Jérémy Compostella, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83318?usp=email
to look at the new patch set (#14).
The following approvals got outdated and were removed: Code-Review+1 by Shuo Liu, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/common/systemagent: fixup systemagent address ......................................................................
soc/intel/common/systemagent: fixup systemagent address
System agent in Intel common block (1) assumes TOLUD and TOUUD registers hold the max available address plus 1, but on some SoC like Snow Ridge, it holds the max available address; (2) aligns TOLUD, TOUUD and TSEG registers to 1 MiB default, but some SoC may have different alignments. This patch add a new function soc_systemagent_fixup_address() to improve it.
Change-Id: If32c2a6524c9d55ce7f9c3dd203bcf85cab76c2c Signed-off-by: Yuchi Chen yuchi.chen@intel.com --- M src/soc/intel/common/block/include/intelblocks/systemagent.h M src/soc/intel/common/block/systemagent/Kconfig M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/common/block/systemagent/systemagent_early.c 4 files changed, 58 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/83318/14