Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/60268
to review the following change.
Change subject: docker/Makefile: Use all instead of all_without_gdb ......................................................................
docker/Makefile: Use all instead of all_without_gdb
By removing GDB from crossgcc in commit f32eed16 (buildgcc: Remove GDB from crossgcc), it will fail if we make coreboot-sdk in util/docker.
Set the default CROSSGCC_PARAM from all_without_gdb to all to avoid building deprecated makefile target in crossgcc.
Signed-off-by: Hsuan Ting Chen roccochen@chromium.org Change-Id: I06c6d8e36dfd4e6a00ddec8b640b608ab1ba614c --- M util/docker/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/60268/1
diff --git a/util/docker/Makefile b/util/docker/Makefile index 87e21be..cbe34f9 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -24,7 +24,7 @@ export DOCKER_CCACHE?=$(HOME)/.ccache
# SDK architecture -export COREBOOT_CROSSGCC_PARAM?=all_without_gdb +export COREBOOT_CROSSGCC_PARAM?=all
UID ?= $(shell id -u) GID ?= $(shell id -g)