Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, John Zhao, Tim Wawrzynczak, Patrick Rudolph.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62721 )
Change subject: soc/intel/common: Add IOE P2SB for TCSS
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/soc/intel/common/block/p2sb/ioe_p2sb.c:
https://review.coreboot.org/c/coreboot/+/62721/comment/79eda7ab_2f7c211c
PS2, Line 56: .vendor = PCI_VENDOR_ID_INTEL,
Could you update to PCI_VID_INTEL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01f551b6e1f50ebdc1cef2ceee815a492030db19
Gerrit-Change-Number: 62721
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 11 Mar 2022 01:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment