Change in coreboot[master]: mb/google/volteer: Change default camera power GPIO to 0

[Daniel Kang (Code Review)]

Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

mb/google/volteer: Change default camera power GPIO to 0

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be a just blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer proto 2 board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang 
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45058/1

diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c
index fd355a8..693cf1b 100644
--- a/src/mainboard/google/volteer/variants/volteer/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer/gpio.c
@@ -93,9 +93,9 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_NC(GPP_D16, UP_20K),
    /* D17 : ISH_GP4 ==> EN_FCAM_PWR */
-	PAD_CFG_GPO(GPP_D17, 1, DEEP),
+	PAD_CFG_GPO(GPP_D17, 0, DEEP),
    /* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_D18, 1, DEEP),
+	PAD_CFG_GPO(GPP_D18, 0, DEEP),

/* E1  : SPI1_IO2 ==> PEN_DET_ODL */
    PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE),
@@ -154,7 +154,7 @@
    /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */
    PAD_CFG_GPI(GPP_H13, NONE, DEEP),
    /* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_H14, 1, DEEP),
+	PAD_CFG_GPO(GPP_H14, 0, DEEP),
    /* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */
    PAD_CFG_GPI(GPP_H15, NONE, DEEP),
    /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */
@@ -164,7 +164,7 @@
    /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */
    PAD_CFG_GPI(GPP_H19, NONE, DEEP),
    /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */
-	PAD_CFG_GPO(GPP_H20, 1, DEEP),
+	PAD_CFG_GPO(GPP_H20, 0, DEEP),
    /* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */
    PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
    /* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 1:

(1 comment)

btw., can we switch to
chip drivers/intel/mipi_camera
in the device tree?

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/gpio.c:

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
PS1, Line 129: RCAM_RST_L
should we assert reset as well?
(already done for FCAM_RST_L)

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> btw., can we switch to
> chip drivers/intel/mipi_camera
> in the device tree?

Yes, it's on my list of things to do, but as what we have is currently functional, it's not very high priority for me right now.

[Daniel Kang (Code Review)]

Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/gpio.c:

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
PS1, Line 129: RCAM_RST_L
> should we assert reset as well? […]

The comment is not right anymore. RCAM_RST_L(F15) was assigned for the rear camera reset in the previous version of the HW.  But now they changed to share the same D4 for both rear and front camera reset.  And D4 is set as assert reset.

[Daniel Kang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Bingbu Cao, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45058

to look at the new patch set (#2).

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

mb/google/volteer: Change default camera power GPIO to 0

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be a just blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer proto 2 board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang 
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
2 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45058/2

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#3) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

mb/google/volteer: Change default camera power GPIO to 0

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be a just blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang 
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
2 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45058/3

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45058/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45058/3//COMMIT_MSG@15 
PS3, Line 15: a just
just a

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#4) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

mb/google/volteer: Change default camera power GPIO to 0

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be just a blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang 
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
2 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45058/4

[Daniel H Kang (Code Review)]

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45058/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45058/3//COMMIT_MSG@15 
PS3, Line 15: a just
> just a

Done

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 4: Code-Review+1

[Daniel Kang (Code Review)]

Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/gpio.c:

https://review.coreboot.org/c/coreboot/+/45058/1/src/mainboard/google/voltee... 
PS1, Line 129: RCAM_RST_L
> The comment is not right anymore. […]

Done

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45058 )

Change subject: mb/google/volteer: Change default camera power GPIO to 0
......................................................................

mb/google/volteer: Change default camera power GPIO to 0

The default GPIO values for camera power were set as 1 so the LED was
turned on by default when the board is powered on.
This status is kept until the camera is probed then being turned off.
So the LED is turned on for a few seconds during the boot up.

By setting the default power to 0, the LED is lit only when camera
is turned on for probing and this should be just a blink.

BUG=b:167635396
BRANCH=none
TEST=Build and boot volteer board. Monitor camera privacy LED
and check it is not lit more than 0.5 seconds.

Signed-off-by: Daniel Kang 
Change-Id: Ic7df391aa512daafe6e1ce49e9222b90e17ad806
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45058
Reviewed-by: Caveh Jalali 
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Caveh Jalali: Looks good to me, but someone else must approve
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c
index 422764e..1077fa1 100644
--- a/src/mainboard/google/volteer/variants/volteer/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer/gpio.c
@@ -93,9 +93,9 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_NC(GPP_D16, UP_20K),
    /* D17 : ISH_GP4 ==> EN_FCAM_PWR */
-	PAD_CFG_GPO(GPP_D17, 1, DEEP),
+	PAD_CFG_GPO(GPP_D17, 0, DEEP),
    /* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_D18, 1, DEEP),
+	PAD_CFG_GPO(GPP_D18, 0, DEEP),

/* E1  : SPI1_IO2 ==> PEN_DET_ODL */
    PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE),
@@ -154,7 +154,7 @@
    /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */
    PAD_CFG_GPI(GPP_H13, NONE, DEEP),
    /* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_H14, 1, DEEP),
+	PAD_CFG_GPO(GPP_H14, 0, DEEP),
    /* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */
    PAD_CFG_GPI(GPP_H15, NONE, DEEP),
    /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */
@@ -164,7 +164,7 @@
    /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */
    PAD_CFG_GPI(GPP_H19, NONE, DEEP),
    /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */
-	PAD_CFG_GPO(GPP_H20, 1, DEEP),
+	PAD_CFG_GPO(GPP_H20, 0, DEEP),
    /* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */
    PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
    /* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */
diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c
index 124f220..6c67fc2 100644
--- a/src/mainboard/google/volteer/variants/volteer2/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c
@@ -93,9 +93,9 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_NC(GPP_D16, UP_20K),
    /* D17 : ISH_GP4 ==> EN_FCAM_PWR */
-	PAD_CFG_GPO(GPP_D17, 1, DEEP),
+	PAD_CFG_GPO(GPP_D17, 0, DEEP),
    /* D18 : ISH_GP5 ==> FCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_D18, 1, DEEP),
+	PAD_CFG_GPO(GPP_D18, 0, DEEP),

/* E1  : SPI1_IO2 ==> PEN_DET_ODL */
    PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE),
@@ -154,7 +154,7 @@
    /* H13 : M2_SKT2_CFG1 # ==> WWAN_CONFIG1 */
    PAD_CFG_GPI(GPP_H13, NONE, DEEP),
    /* H14 : M2_SKT2_CFG2 # ==> RCAM_SNRPWR_EN */
-	PAD_CFG_GPO(GPP_H14, 1, DEEP),
+	PAD_CFG_GPO(GPP_H14, 0, DEEP),
    /* H15 : M2_SKT2_CFG3 # ==> WWAN_CONFIG3 */
    PAD_CFG_GPI(GPP_H15, NONE, DEEP),
    /* H16 : DDPB_CTRLCLK ==> DDPB_HDMI_CTRLCLK */
@@ -164,7 +164,7 @@
    /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */
    PAD_CFG_GPI(GPP_H19, NONE, DEEP),
    /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */
-	PAD_CFG_GPO(GPP_H20, 1, DEEP),
+	PAD_CFG_GPO(GPP_H20, 0, DEEP),
    /* H21 : IMGCLKOUT2 ==> CAM_MCLK1 */
    PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
    /* H22 : IMGCLKOUT3 ==> CAM_MCLK0 */