Selma Bensaid has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68635 )
Change subject: [Chromium] soc/intel/alderlake: Hook up DisableDynamicTccoldHandshake to dev tree ......................................................................
[Chromium] soc/intel/alderlake: Hook up DisableDynamicTccoldHandshake to dev tree
This commit provides a dev tree setting for partners to enable/disable TccoldHandshake for the sighting in doc:723158
BUG=b:221461379 BRANCH=firmware-brya-14505.B TEST=compile ok and FSP UPD is config properly Signed-off-by: Kane Chen kane.chen@intel.corp-partner.google.com
Change-Id: Ica13b98204acebef7f0b9a4411b4ac19f53cad6e --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/fsp_params.c 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/68635/1
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h index 4cb6066..1847aca 100644 --- a/src/soc/intel/alderlake/chip.h +++ b/src/soc/intel/alderlake/chip.h @@ -646,6 +646,13 @@ * Default is set to 0 and set to 1 to skip the MBP HOB. */ bool skip_mbp_hob; + + /* + * Enable or Disable Tccold Handshake + * Default is set to 0. + * Set this to 1 in order to disable Tccold Handshake + */ + bool disable_dynamic_tccold_handshake; };
typedef struct soc_intel_alderlake_config config_t; diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index c0bdb0d..531b924 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -266,6 +266,9 @@ /* TCSS DMA */ m_cfg->TcssDma0En = is_devfn_enabled(SA_DEVFN_TCSS_DMA0); m_cfg->TcssDma1En = is_devfn_enabled(SA_DEVFN_TCSS_DMA1); + + m_cfg->DisableDynamicTccoldHandshake = + config->disable_dynamic_tccold_handshake; }
static void fill_fspm_usb4_params(FSP_M_CONFIG *m_cfg,