Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42735 )
Change subject: vendorcode/google/chromeos: Add GOOG0016 _HID for Chrome OS ACPI ......................................................................
vendorcode/google/chromeos: Add GOOG0016 _HID for Chrome OS ACPI
The Chrome OS ACPI code has always used a legacy PNP ID "GGL0001" for the ID. This is technically valid but we have an official ACPI ID now so I allocated "GOOG0016" for an ID and we can eventually retire the legacy PNP ID.
This is being discussed on LKML as part of an effort to upstream the Chrome OS ACPI kernel driver: https://lkml.org/lkml/2020/4/13/315
Change-Id: I2e41fe419113b327618f8f98058ef7af657f2532 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/vendorcode/google/chromeos/acpi/chromeos.asl 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/42735/1
diff --git a/src/vendorcode/google/chromeos/acpi/chromeos.asl b/src/vendorcode/google/chromeos/acpi/chromeos.asl index 5c8af4e..7642676 100644 --- a/src/vendorcode/google/chromeos/acpi/chromeos.asl +++ b/src/vendorcode/google/chromeos/acpi/chromeos.asl @@ -9,7 +9,8 @@
Device (CRHW) { - Name(_HID, EISAID("GGL0001")) + Name(_HID, "GOOG0016") + Name(_CID, EISAID("GGL0001"))
Method(_STA, 0, Serialized) {
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42735 )
Change subject: vendorcode/google/chromeos: Add GOOG0016 _HID for Chrome OS ACPI ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42735 )
Change subject: vendorcode/google/chromeos: Add GOOG0016 _HID for Chrome OS ACPI ......................................................................
vendorcode/google/chromeos: Add GOOG0016 _HID for Chrome OS ACPI
The Chrome OS ACPI code has always used a legacy PNP ID "GGL0001" for the ID. This is technically valid but we have an official ACPI ID now so I allocated "GOOG0016" for an ID and we can eventually retire the legacy PNP ID.
This is being discussed on LKML as part of an effort to upstream the Chrome OS ACPI kernel driver: https://lkml.org/lkml/2020/4/13/315
Change-Id: I2e41fe419113b327618f8f98058ef7af657f2532 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42735 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/vendorcode/google/chromeos/acpi/chromeos.asl 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/vendorcode/google/chromeos/acpi/chromeos.asl b/src/vendorcode/google/chromeos/acpi/chromeos.asl index 5c8af4e..7642676 100644 --- a/src/vendorcode/google/chromeos/acpi/chromeos.asl +++ b/src/vendorcode/google/chromeos/acpi/chromeos.asl @@ -9,7 +9,8 @@
Device (CRHW) { - Name(_HID, EISAID("GGL0001")) + Name(_HID, "GOOG0016") + Name(_CID, EISAID("GGL0001"))
Method(_STA, 0, Serialized) {