Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52763 )
Change subject: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52763/comment/2b3da2de_17ea8a67
PS1, Line 9: GPIOs can only be updated in gpio_configure_pads_with_override() if they
: are present in the base table. If they are not there, the override
: does not work. This allows them to be in the base table so that they can
: be overridden without changing the existing configuration.
Why must a mainboard configure all pads in ramstage? […]
How about instead of requiring that everything be programmed in romstage, we add a check at finalize that actually verifies the GPIO programming is for each GPIO is how we want ii and assert if it are not. That accomplishes both of our goals without making a rule that needs to be followed by the individual programmer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e5e7b7d30f2c89fa1db375ddba394e6914d97b9
Gerrit-Change-Number: 52763
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 04 May 2021 15:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment