Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58149 )
Change subject: soc/intel/*/me.c: Check more than PCI interface for printing ME info ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/58149/comment/808f38a6_90c611c8 PS1, Line 103: !cse_is_hfs1_cws_normal() || : !cse_is_hfs1_com_normal() || : !cse_is_hfs1_com_soft_temp_disable()) : return;
I disagree here, this is important status information to have on every boot, especially when it's no […]
I think you agree - unless my brain stopped working and my logic is wrong...
Currently, it won't print the status if the PCI device is not enabled - I think that's irrelevant as that's not how we talk to it.
Removing things doesn't go down too well in coreboot, so I thought the compromise would be to print the status if it's in a known state or the PCI device is enabled.