Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal, Eric Lai.
Yong Zhi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73061 )
Change subject: soc/intel/meteorlake: Add PM Energy Report feature option
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/73061/comment/7d6d02fe_807c9ac7
PS1, Line 649: s_cfg->PchPmDisableEnergyReport = !config->pch_pm_energy_report_enable;
Do you want default is disable? If no one set this, it will be true.
That's correct, default value of PchPmDisableEnergyReport in FSP is 1, the feature is intended for power instrumentation of eng build/RVP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58d4aea28ee2561d2ed73260c40cb22ce3fdd135
Gerrit-Change-Number: 73061
Gerrit-PatchSet: 1
Gerrit-Owner: Yong Zhi
yong.zhi@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 16 Feb 2023 01:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment