Attention is currently required from: YH Lin, Zhuohao Lee, Raihow Shi, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62770 )
Change subject: mb/google/brask/variants/moli: set eMMC pin in bootblock
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62770/comment/f8d647a3_dfb8316d
PS3, Line 9: 1.add eMMC enable pin in bootblock
: 2.set eMMC reset pin unable in bootblock
suggestion:
```
1. Assert eMMC enable pin in bootblock
2. Deassert eMMC reset pin in bootblock
```
Also should reset be deasserted after power enable? in other words, should the controller be powered on with reset asserted (in reset)?
https://review.coreboot.org/c/coreboot/+/62770/comment/9520dc41_3bbb44e8
PS3, Line 12:
nit: remove extra blank line
File src/mainboard/google/brya/variants/moli/gpio.c:
https://review.coreboot.org/c/coreboot/+/62770/comment/665c78d8_6ec1ef4a
PS3, Line 73: /* B3 : PROC_GP2 ==> EMMC_PERST_L */
: PAD_CFG_GPO(GPP_B3, 0, DEEP),
:
Please keep line 75 and 73 together, the comment goes with the pad programming
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I924fcdadaae8ed29b50369a55bad00983cf6ba19
Gerrit-Change-Number: 62770
Gerrit-PatchSet: 3
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Mar 2022 17:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment