Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76108?usp=email )
Change subject: soc/amd/common/fsp: Fix dimm_num assignment ......................................................................
soc/amd/common/fsp: Fix dimm_num assignment
The dimm_num shall be dimm, not channel.
BUG=b:288520486 TEST=In kernel, see output from `dmidecode -t 17`. Observe that Locator reflects proper location of the module.
Change-Id: Id876a5c245ed1a145c930b3456830d7b42780b74 Signed-off-by: Konrad Adamczyk konrada@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/76108 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/common/fsp/dmi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/amd/common/fsp/dmi.c b/src/soc/amd/common/fsp/dmi.c index a671476..408c0e4 100644 --- a/src/soc/amd/common/fsp/dmi.c +++ b/src/soc/amd/common/fsp/dmi.c @@ -226,7 +226,7 @@ print_dmi_info(type17_dmi_info); dimm_info = &mem_info->dimm[dimm_cnt]; dimm_info->channel_num = channel; - dimm_info->dimm_num = channel; + dimm_info->dimm_num = dimm; transfer_memory_info(type17_dmi_info, dimm_info); if (use_cbi_part_number) { /* mem_info is memset to 0 above, so it's