Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31586 )
Change subject: flapjack: get sku_id from ec (cbi)
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31586/4/src/mainboard/google/kukui/boardid.c
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/31586/4/src/mainboard/google/kukui/boardid.c...
PS4, Line 22: 2
We discussed this further and decided to use 0 to indicate unprovisioned boards or corrupted CBI. Old boards with old firmware still return 2 but we won't deal with this combination.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7a52df38e2045abbdded8ba0a1f1544de961fc
Gerrit-Change-Number: 31586
Gerrit-PatchSet: 4
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nick Sanders
nsanders@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 17:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment