Attention is currently required from: Eric Lai, Kane Chen, Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog ......................................................................
Patch Set 23:
(1 comment)
Patchset:
PS23: couple of questions
1. why redundant entries ? is that for soC PMC and IOE PMC?
[DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400 [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280 [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80 [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280 [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e [DEBUG] Region[0x7].Tag=0x0 offset=0x0, size=0x0
[DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400 [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280 [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80 [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280 [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
2. summation of all PMC crashlog size entries are not matching with below crashlog size.
[DEBUG] PMC crashLog size : 0x2808
3. can you please make sure to either use hex or decimal and not the mix
example:
[DEBUG] cl_data 0x75b4b07c, cpu_record_size 25164 [DEBUG] CPU crash data collection. [DEBUG] cl_data 0x75b51330, pmc_record_size 7208 [DEBUG] PMC crash data collection. [DEBUG] cl_data 0x75b52fc0, ioe_record_size 2600
and
crashlog size:pmc-0x1c28, ioe-pmc-0xa28 cpu-0x624c