Attention is currently required from: Felix Held, Fred Reitberger, Grzegorz Bernacki, Jason Glenesk, Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Raul Rangel.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Raul Rangel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75621?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: mb/google: AMD: move tpm_tis to AMD common code ......................................................................
mb/google: AMD: move tpm_tis to AMD common code
It moves tis_plat_irq_status() to common code and adds Kconfig option to specify GPIO used for interrupt.
BUG=b:277787305 TEST=Build all affected platform and confirm using right GPIO number. Tested on Skyrim.
Change-Id: I775c4e24cffee99b6ac3e05b58a75425029a86c8 Signed-off-by: Grzegorz Bernacki bernacki@google.com --- M src/drivers/tpm/cr50.h M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/variants/baseboard/Makefile.inc D src/mainboard/google/guybrush/variants/baseboard/tpm_tis.c M src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/tpm_tis.c M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/variants/baseboard/Makefile.inc D src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/variants/baseboard/Makefile.inc D src/mainboard/google/myst/variants/baseboard/tpm_tis.c M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/variants/baseboard/Makefile.inc D src/mainboard/google/skyrim/variants/baseboard/tpm_tis.c M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/variants/baseboard/Makefile.inc D src/mainboard/google/zork/variants/baseboard/tpm_tis.c M src/soc/amd/common/block/gpio/Kconfig M src/soc/amd/common/block/gpio/Makefile.inc A src/soc/amd/common/block/gpio/tpm_tis.c 21 files changed, 70 insertions(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/75621/2
-
Grzegorz Bernacki (Code Review)