Change in ...coreboot[master]: drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure - coreboot-gerrit

18 Mar 2019


      Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29329 )
Change subject: drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure
......................................................................
Patch Set 5:
...
Patch Set 5:
I had another look at the callers of cmos_init()...
it seems the API is generally misused. I get the
feeling that we should generally treat `cmos_valid`
and `valid` the same.
Reason for patch are systems where the RTC seems to be valid, but chipset indicates power failure.
To have RTC date reset the cmos_invalid must become true.
Handling `cmos_valid` and `valid` the same will work for us.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206
Gerrit-Change-Number: 29329
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 18 Mar 2019 11:17:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment