Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41029 )
Change subject: soc/intel/jasperlake: Allow SataEnable to be filled from devicetree
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
PS6, Line 139: dev->enabled
If we can use dev->enabled, is there any point in using SataEnable config? Can we drop it and just use dev->enabled instead?
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
PS6, Line 140: SataEnable
I believe there are generally more params that you would have to set when Sata is being enabled? Like SataMode, SataPortsDevSlp and so on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f7e7508b8cd483508293ee3e7b760574d8f025f
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 6
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 May 2020 17:34:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment