Attention is currently required from: Hung-Te Lin, Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes
......................................................................
Patch Set 16:
(1 comment)
File src/vendorcode/mediatek/Kconfig:
https://review.coreboot.org/c/coreboot/+/50294/comment/ceae23b5_9afb7945
PS16, Line 3: config DEBUG_DRAM
: bool "Output verbose DRAM related debug messages"
: default y
: help
: This option enables additional DRAM related debug messages.
this is the only config in dramc. […]
I'd suggest reusing the existing `DEBUG_RAM_SETUP` Kconfig option. It is shown when `HAVE_DEBUG_RAM_SETUP` is selected.
For the debug macro, I'd use the Kconfig value directly so that the compiler can optimize unused code away in non-debug builds:
#define dramc_dbg(_x_...) do { \
if (CONFIG(DEBUG_DRAM)) \
printk(BIOS_INFO, _x_); \
} while (0)
The do-while construct in macros is used to "swallow the semicolon": https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 16
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
reinauer@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment